Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update useOnWindowResize #1062

Merged
merged 1 commit into from
May 25, 2024
Merged

fix: update useOnWindowResize #1062

merged 1 commit into from
May 25, 2024

Conversation

severinlandolt
Copy link
Member

Description

This PR fixes onWindowResize exceeding the max render depth

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

Storybook

Screenshots (if appropriate):

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 1:45pm

@christopherkindl christopherkindl self-requested a review May 25, 2024 13:52
@severinlandolt severinlandolt merged commit 3dc49f9 into main May 25, 2024
6 checks passed
Copy link

🎉 This PR is included in version 3.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@severinlandolt severinlandolt deleted the fix/resizehook branch June 21, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resizing window triggers maximum update depth exceeded in next js 14.0.2
2 participants