Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url and connector naming #2640

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix url and connector naming #2640

merged 2 commits into from
Jul 25, 2024

Conversation

Licenser
Copy link
Member

Pull request

Description

a quick fix for #2639

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@Licenser Licenser enabled auto-merge (rebase) July 19, 2024 16:31
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (1088f39) to head (6c020b1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2640   +/-   ##
=======================================
  Coverage   91.27%   91.28%           
=======================================
  Files         309      309           
  Lines       60870    60873    +3     
=======================================
+ Hits        55559    55565    +6     
+ Misses       5311     5308    -3     
Flag Coverage Δ
e2e-command 11.12% <0.00%> (ø)
e2e-integration 51.81% <33.33%> (+<0.01%) ⬆️
e2e-unit 12.32% <0.00%> (ø)
e2etests 54.10% <33.33%> (+<0.01%) ⬆️
tremorapi 14.23% <33.33%> (ø)
tremorcodec 62.94% <ø> (ø)
tremorcommon 63.04% <ø> (ø)
tremorconnectors 29.04% <ø> (-0.01%) ⬇️
tremorconnectorsaws 11.45% <ø> (ø)
tremorconnectorsazure 4.95% <ø> (ø)
tremorconnectorsgcp 21.08% <100.00%> (+0.01%) ⬆️
tremorconnectorsobjectstorage 0.06% <ø> (ø)
tremorconnectorsotel 12.52% <ø> (ø)
tremorconnectorstesthelpers 60.56% <ø> (ø)
tremorinflux 87.72% <ø> (ø)
tremorinterceptor 54.33% <ø> (ø)
tremorpipeline 31.10% <ø> (ø)
tremorruntime 46.48% <33.33%> (+0.01%) ⬆️
tremorscript 54.28% <ø> (ø)
tremorsystem 5.74% <ø> (ø)
tremorvalue 70.16% <ø> (ø)
unittests 88.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tremor-connectors-gcp/src/gbq/writer.rs 94.44% <100.00%> (ø)
tremor-connectors-gcp/src/gcs.rs 100.00% <ø> (ø)
...-connectors-gcp/src/gcs/resumable_upload_client.rs 90.35% <100.00%> (+0.05%) ⬆️
tremor-connectors-gcp/src/gcs/streamer.rs 98.99% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1088f39...6c020b1. Read the comment docs.

darach
darach previously approved these changes Jul 22, 2024
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤦

@Licenser Licenser merged commit 7c31df5 into main Jul 25, 2024
58 checks passed
@Licenser Licenser deleted the gcp-fixes branch July 25, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP resumable_upload_client points to incorrect API endpoint.
2 participants