Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brotli compression and decompression #2515

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

Licenser
Copy link
Member

Pull request

Description

Brotli is a modern compression with a focus on HTTP, it's nice to support it. it's worth mentioning that brotli has no magic bytes so we can not autodetect it.

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 90.81%. Comparing base (efd2001) to head (709e637).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2515      +/-   ##
==========================================
+ Coverage   90.74%   90.81%   +0.06%     
==========================================
  Files         299      299              
  Lines       58847    58886      +39     
==========================================
+ Hits        53403    53476      +73     
+ Misses       5444     5410      -34     
Flag Coverage Δ
e2e-command 11.49% <0.00%> (-0.01%) ⬇️
e2e-integration 51.35% <0.00%> (+0.15%) ⬆️
e2e-unit 12.74% <0.00%> (-0.02%) ⬇️
e2etests 53.75% <0.00%> (+0.15%) ⬆️
tremorapi 14.61% <0.00%> (-0.02%) ⬇️
tremorcodec 63.82% <ø> (ø)
tremorcommon 57.57% <ø> (ø)
tremorconnectors 27.33% <0.00%> (-0.03%) ⬇️
tremorconnectorsaws 11.12% <0.00%> (-0.02%) ⬇️
tremorconnectorsgcp 20.61% <0.00%> (+0.12%) ⬆️
tremorconnectorsobjectstorage 0.00% <ø> (ø)
tremorconnectorsotel 12.75% <0.00%> (-0.02%) ⬇️
tremorconnectorstesthelpers 60.56% <ø> (ø)
tremorinflux 87.72% <ø> (ø)
tremorinterceptor 52.82% <83.33%> (+0.27%) ⬆️
tremorpipeline 30.74% <ø> (ø)
tremorruntime 47.80% <0.00%> (-0.03%) ⬇️
tremorscript 54.11% <ø> (ø)
tremorsystem 5.37% <ø> (ø)
tremorvalue 72.45% <ø> (ø)
unittests 88.03% <83.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tremor-interceptor/src/postprocessor/compress.rs 83.53% <82.35%> (-0.09%) ⬇️
tremor-interceptor/src/preprocessor/decompress.rs 87.54% <84.00%> (-0.11%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd2001...709e637. Read the comment docs.

@Licenser Licenser merged commit 7bf03e8 into main Apr 23, 2024
56 checks passed
@Licenser Licenser deleted the br-compression branch April 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants