fix: don't allow duplicate stream names#1220
Merged
Licenser merged 1 commit intotremor-rs:mainfrom Sep 17, 2021
rawkode:main
Merged
fix: don't allow duplicate stream names#1220Licenser merged 1 commit intotremor-rs:mainfrom rawkode:main
Licenser merged 1 commit intotremor-rs:mainfrom
rawkode:main
Conversation
rawkode
requested review from
Licenser,
anupdhml,
darach and
mfelsche
as code owners
Signed-off-by: David McKay <david@rawkode.com>
Licenser
approved these changes
Sep 17, 2021
Member
Licenser
left a comment
Licenser
left a comment
There was a problem hiding this comment.
This looks awesome! Thank you for picking it up 🚀
darach
approved these changes
Sep 17, 2021
Member
darach
left a comment
darach
left a comment
There was a problem hiding this comment.
As seen live on LGTM with the host with the most - rawkode!
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David McKay david@rawkode.com
Pull request
Description
Currently tremor-script allows multiple streams with the same name. Let's not allow that.
Closes #1212
Checklist