Skip to content

Include a vary: origin header #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Include a vary: origin header #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0429a54
Include a vary: origin header
acoburn Mar 3, 2021
c5d828d
Merge branch 'main' into feature/vary-origin
acoburn Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/common/src/main/java/org/trellisldp/common/HttpConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ public final class HttpConstants {
/** The name of the HTTP response code for a Precondition Required error. */
public static final int PRECONDITION_REQUIRED = 428;

/** The name of the HTTP request header indicating a browser's origin. */
public static final String ORIGIN = "Origin";

/** The name of the HTTP request header used to influence what information is included in responses. */
public static final String PREFER = "Prefer";

Expand Down
2 changes: 2 additions & 0 deletions core/http/src/main/java/org/trellisldp/http/impl/GetHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import static org.trellisldp.common.HttpConstants.ACCEPT_RANGES;
import static org.trellisldp.common.HttpConstants.DESCRIPTION;
import static org.trellisldp.common.HttpConstants.MEMENTO_DATETIME;
import static org.trellisldp.common.HttpConstants.ORIGIN;
import static org.trellisldp.common.HttpConstants.PREFER;
import static org.trellisldp.common.HttpConstants.PREFERENCE_APPLIED;
import static org.trellisldp.common.HttpConstants.RANGE;
Expand Down Expand Up @@ -391,6 +392,7 @@ private CompletionStage<InputStream> getBinaryStream(final IRI dsid, final Trell
private String buildVaryHeader(final boolean isLdpRs) {
final List<String> variants = new ArrayList<>();
variants.add(ACCEPT);
variants.add(ORIGIN);
if (!isMemento) {
variants.add(ACCEPT_DATETIME);
}
Expand Down