Skip to content

Watch all workspace folders for changes in dot folders #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattseddon merged 2 commits into from
Apr 27, 2023
Merged

Watch all workspace folders for changes in dot folders #3769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a588079
Watch all workspace folders for changes in dot folders
mattseddon Apr 27, 2023
d4a503f
Merge branch 'main' into fix-dot-folder-watcher
mattseddon Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions extension/src/setup/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,21 +578,17 @@ export class Setup
}

private watchDotFolderForChanges() {
const cwd = getFirstWorkspaceFolder()

if (!cwd) {
return
}

const disposer = Disposable.fn()
this.dotFolderWatcher = disposer
this.dispose.track(this.dotFolderWatcher)

return createFileSystemWatcher(
disposable => disposer.track(disposable),
getRelativePattern(cwd, '**'),
path => this.dotFolderListener(disposer, path)
)
for (const workspaceFolder of getWorkspaceFolders()) {
Copy link
Contributor Author

@mattseddon mattseddon Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] There was a small chance of a bug here when the user has multiple workspace folders. We can easily watch multiple folders for changes.

createFileSystemWatcher(
disposable => disposer.track(disposable),
getRelativePattern(workspaceFolder, '**'),
path => this.dotFolderListener(disposer, path)
)
}
}

private dotFolderListener(disposer: Disposer, path: string) {
Expand Down