Skip to content

Fix scheduled CLI output test by updating expected demo project output (plots diff breaking change) #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattseddon merged 1 commit into from
Apr 2, 2023
Merged

Fix scheduled CLI output test by updating expected demo project output (plots diff breaking change) #3558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions extension/src/test/cli/plotsDiff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import {
PlotsType,
TemplatePlot
} from '../../plots/webview/contract'
import { EXPERIMENT_WORKSPACE_ID } from '../../cli/dvc/contract'
import { EXPERIMENT_WORKSPACE_ID, PlotsOutput } from '../../cli/dvc/contract'
import { isDvcError } from '../../cli/dvc/reader'

suite('plots diff -o <TEMP_DIR> --split --show-json', () => {
// eslint-disable-next-line sonarjs/cognitive-complexity
Expand All @@ -24,14 +25,15 @@ suite('plots diff -o <TEMP_DIR> --split --show-json', () => {
)

expect(output, 'should be an object').to.be.an('object')
expect(isDvcError(output), 'should not be an error object').to.be.false
const data = (output as PlotsOutput)?.data

expect(
Object.keys(output),
'should have six plot paths'
).to.have.lengthOf(6)
expect(Object.keys(data), 'should have six plot paths').to.have.lengthOf(
6
)

// each set of plots under a path
for (const plots of Object.values(output)) {
for (const plots of Object.values(data)) {
expect(plots, 'should have plots under each path').to.be.an('array')
expect(
plots,
Expand Down Expand Up @@ -95,7 +97,7 @@ suite('plots diff -o <TEMP_DIR> --split --show-json', () => {
await initializeEmptyRepo()
const output = await dvcReader.plotsDiff(TEMP_DIR)

expect(output).deep.equal({})
expect(output).deep.equal({ data: {} })
})
})
})