Account for data key being optional in plots diff output #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2023
mattseddon
force-pushed
the
make-data-optional
branch
from
5b0d6a2 to
e9f1441
Compare
This was referenced Mar 24, 2023
sroy3
approved these changes
Mar 24, 2023
julieg18
approved these changes
Mar 24, 2023
mattseddon
force-pushed
the
move-error-tooltip
branch
from
ffcec70 to
31a1adf
Compare
mattseddon
force-pushed
the
make-data-optional
branch
from
e9f1441 to
67de213
Compare
|
Code Climate has analyzed commit 67de213 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8/9
main<- #3477 <- #3520 <- #3522 <- #3532 <- #3544 <- #3545 <- #3546 <- this <- #3548This PR makes sure that we account for the data key being optional in
plots diff. We do this at the boundary of the system instead of checking for the presence of the key all through the collection code.