Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature:
Labeled tuples are annoying to parse, since the interaction with labeled function arguments makes the grammar not LR(1).
When parsing
you don't know whether the
x:is a tuple label (first case) or function argument label (second case) until the->.The OCaml parser handles that by incorrectly parsing the first one as
x:(t1 * t2), and post-processing it tox:t1 * t2. We can't do that in tree-sitter.This means we have to introduce our first conflict in the grammar. That's not a problem at all, but I liked that tree-sitter-ocaml was conflict free until now.
Fixes #121.