Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css) :host parsing now works #62

Closed
wants to merge 1 commit into from
Closed

fix(css) :host parsing now works #62

wants to merge 1 commit into from

Conversation

mohamedmansour
Copy link

Fixes #61

Previously :host was failing to parse so all selectors within it are not recognizable. Now it works as expected.

@mohamedmansour
Copy link
Author

@amaanq can you please review at your convenience! Thank you! Btw why do we have to check in the generated code? Couldn't the CI just run "tree-sitter generate" instead?

@mohamedmansour
Copy link
Author

@amaanq any update on this review please, :host is the most important CSS element for Shadow Roots

ObserverOfTime
ObserverOfTime suggested changes Jan 11, 2025
View reviewed changes
Copy link
Member

@ObserverOfTime ObserverOfTime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right fix here is to remove host from the list.

@amaanq amaanq mentioned this pull request Jan 11, 2025
Merged
@amaanq
Copy link
Member

amaanq commented Jan 11, 2025

Superseded by #64, sorry about the delay

@amaanq amaanq closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ObserverOfTime ObserverOfTime ObserverOfTime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: failed to parse :host pseudo class
3 participants
@mohamedmansour @amaanq @ObserverOfTime