Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern matching improvements #355

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vanessa-rodrigues
Copy link

  • Allows single sub pattern in positional pattern clauses.
  • Allows variable designation in list patterns.
  • Allows name_colon in sub pattern.

Reference:
https://github.com/dotnet/roslyn/blob/main/src/Compilers/CSharp/Portable/Generated/CSharp.Generated.g4

@vanessa-rodrigues
Copy link
Author

Parsing examples/nunit/src/NUnitFramework/tests/Attributes/TestCaseAttributeTests.cs seems to fail even before my changes.

@amaanq
Copy link
Member

amaanq commented Nov 10, 2024

Parsing examples/nunit/src/NUnitFramework/tests/Attributes/TestCaseAttributeTests.cs seems to fail even before my changes.

Yeah that's fine, looks like a file missing from the excluded list in CI. Do you mind rebasing to resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants