Add var to contextual keywords
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
damieng
reviewed
Jan 13, 2023
grammar.js
Outdated
| [$._type_name, $._array_base_type], | ||
| [$._type_name, $._pointer_base_type], | ||
| [$._type_name, $._ref_base_type], | ||
|
|
There was a problem hiding this comment.
Can you rebase and run with the line number scripts. I'm getting anxious about all these conflict rules.
There was a problem hiding this comment.
After the rebase, these are not needed. I've pushed a commit with the file sizes, there's basically no change.
tamasvajk
force-pushed
the
contextual-keywords-var
branch
from
f85da59 to
524eb59
Compare
damieng
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.
Adding
varas a contextual keyword meant that implicit type and name conflicted, and because they could show up in the same position in an AST as a type, dynamic precedence was specified to prefer implicit type. I didn't want to modify the_namerule, but only cases when_nameis used as a type, so I introduced an intermediate wrapper that adds the dynamic precedence.