fix: reduce javadoc logo height to prevent navbar overflow #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #154 - Logo in javadoc navbar was overflowing due to
height: 100%
Why
height: 100%
didn't work:The logo's direct parent is
.about-language
, not.top-nav
, so100%
referenced an intermediate parent without explicit height. This caused the logo to render at its original image size, exceeding the navbar bounds.Why
calc(0.8 * var(--top-nav-height))
fixes it:em
Changes
Modified
pom.xml
to change logo height from100%
tocalc(0.8 * var(--top-nav-height))
in the javadoc header configuration.Testing
Screenshots
Before: Logo extends beyond navbar

After: Logo contained within navbar

Thanks to @Marcono1234 for suggesting the CSS variable approach!
Fixes #154