Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse variable expansion in include path #17

Conversation

WilsonZiweiWang
Copy link
Contributor

This change should allow the parser to recognize the variable expansion syntax in the include_path.
Example from poky:
https://github.com/yoctoproject/poky/blob/348d9aba3305cd98b0c0b1ec0f4b1407e786307a/meta/recipes-core/glibc/glibc-y2038-tests_2.38.bb#L1

Sample result:
image

@WilsonZiweiWang WilsonZiweiWang force-pushed the Variable-expansion-in-include-path branch from 5137b4c to 21dec1f Compare January 26, 2024 20:31
@amaanq
Copy link
Member

amaanq commented Jan 26, 2024

thanks for the PR. it looks like a few of them fail in your screenshot output, is that intentional because of the unclosed quote? that's fine with me if so

@WilsonZiweiWang
Copy link
Contributor Author

thanks for the PR. it looks like a few of them fail in your screenshot output, is that intentional because of the unclosed quote? that's fine with me if so

yes, I put the " after the $ so none of the choices should match.

@amaanq
Copy link
Member

amaanq commented Jan 26, 2024

just gonna force push your generated changes using tree-sitter cli on master, otherwise LGTM

@amaanq amaanq force-pushed the Variable-expansion-in-include-path branch from 21dec1f to 3ae74ba Compare January 26, 2024 21:32
@amaanq amaanq merged commit 01ead54 into tree-sitter-grammars:master Jan 26, 2024
4 checks passed
@amaanq
Copy link
Member

amaanq commented Jan 26, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants