Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry HTTP GET requests if one fails with 5xx errors #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frsyuki
Copy link
Member

@frsyuki frsyuki commented Aug 2, 2016

Especially including 504 Gateway Timeout.

Especially including 504 Gateway Timeout.
@frsyuki
Copy link
Member Author

frsyuki commented Aug 3, 2016

@miniway could you review this change? I think 504 Gateway Timeout should be retried. But not sure whether all other 5xx errors should be retried or not

@miniway
Copy link
Member

miniway commented Aug 5, 2016

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants