Windows support for signal handling and dealing with IO #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,8 @@ module ServerEngine | |||
| require File.join(here, v) | |||
| } | |||
|
|
|||
| $platformwin = /mswin|mingw/ === RUBY_PLATFORM | |||
There was a problem hiding this comment.
using global variable is not good idea because its name is not in a namespace of ServerEngine.
Why don't you use this way?:
module ServerEngine
def self.windows?
IS_WINDOWS
end
IS_WINDOWS = /mswin|mingw/ === RUBY_PLATFORM
private_constant :IS_WINDOWS
end
There was a problem hiding this comment.
I fixed it.
naritta@5bf96ee
naritta
force-pushed
the
windows-signal-accept
branch
from
6b03b0f to
a87ab06
Compare
| @@ -20,6 +20,9 @@ Gem::Specification.new do |gem| | |||
| gem.required_ruby_version = ">= 1.9.3" | |||
|
|
|||
| gem.add_dependency "sigdump", ["~> 0.2.2"] | |||
| if /mswin|mingw/ =~ RUBY_PLATFORM | |||
There was a problem hiding this comment.
Does this if work when user install serverengine.gem on a windows machine?
To make this work, Rakefile need to create 2 gems (serverengine-VERSION.gem and serverengine-VERSION-mingw.gem), right? I think that is unnecessary optimization because installing win32-pipe does nothing on non-windows platform. So, why don't you simply depend on win32-pipe without if?
|
Merged with #29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In windows,
There is no support for:
・signal except SIGTERM
(Some windows version have, but it is too different in version.)
・read_nonblock IO
Then, I added condition branch.