socket_manager: add feature to share sockets with another server #150
+263
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
add-feature-to-take-over-another-server
branch
3 times, most recently
from
6546cf2 to
03bc031
Compare
|
It would be necessary to consider exclusive locks. |
daipom
force-pushed
the
add-feature-to-take-over-another-server
branch
2 times, most recently
from
772d7df to
13b3d39
Compare
|
Somehow, the fork process couldn't receive SIGTERM, so I gave up using |
daipom
force-pushed
the
add-feature-to-take-over-another-server
branch
from
13b3d39 to
00eba2a
Compare
daipom
changed the title
3 tasks
|
It may be better to note explicitly the scope of this PR (out of scope live-restart for supervisor, we focus on server <=> worker) |
daipom
force-pushed
the
add-feature-to-take-over-another-server
branch
2 times, most recently
from
95ccac0 to
a514542
Compare
|
Thanks for your review! |
Watson1978
reviewed
Oct 22, 2024
|
I'll rebase this. |
Another process can take over UDP/TCP sockets without downtime.
server = ServerEngine::SocketManager::Server.share_sockets_with_another_server(path)
This starts a new server that shares all UDP/TCP sockets with
the existing server.
The old process should stop without removing the file for the
socket after the new process starts.
This allows us to replace both the server and the
workers with new processes without socket downtime.
(The existing live restart feature does not support network
servers. We can restart workers without downtime, but there is
no way to restart the network server without downtime.)
ref: fluent/fluentd#4622
Limitation: This feature would not work well if the process
opens new TCP ports frequently.
Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Shizuo Fujita <[email protected]>
daipom
force-pushed
the
add-feature-to-take-over-another-server
branch
from
1a839c7 to
9a42d6b
Compare
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another process can take over UDP/TCP sockets without downtime.
This starts a new server that shares all UDP/TCP sockets with the existing server.
The old process should stop without removing the file for the socket after the new process starts.
This allows us to replace both the server and the workers with new processes without socket downtime.
(The existing live restart feature does not support network servers.
We can restart workers without socket downtime, but there is no such way for the network server.)
ref: fluent/fluentd#4622
Limitation
address already in useerror.TODO