Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dual stack mode issue for tcp socket with IPv6 #101

Merged
merged 2 commits into from
Nov 17, 2019
Merged

Fix dual stack mode issue for tcp socket with IPv6 #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00bb12
Fix dual stack mode issue for tcp socket with IPv6
repeatedly Nov 14, 2019
db5a6dd
Use Addrinfo class
repeatedly Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/serverengine/socket_manager_unix.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,11 @@ module ServerModule
private

def listen_tcp_new(bind_ip, port)
sock = TCPServer.new(bind_ip.to_s, port)
sock.listen(Socket::SOMAXCONN) # TODO make backlog configurable if necessary
return sock
# TCPServer.new doesn't set IPV6_V6ONLY flag, so use Addrinfo class instead.
# TODO: make backlog configurable if necessary
tsock = Addrinfo.tcp(bind_ip.to_s, port).listen(::Socket::SOMAXCONN)
tsock.autoclose = false
TCPServer.for_fd(tsock.fileno)
end

def listen_udp_new(bind_ip, port)
Expand Down