Skip to content

Implement shallowEquals for SampledRelation #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takezoe merged 1 commit into from
Feb 3, 2022
Merged

Implement shallowEquals for SampledRelation #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions presto-parser/src/main/java/io/prestosql/sql/tree/SampledRelation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,15 @@ public int hashCode()
{
return Objects.hash(relation, type, samplePercentage);
}

@Override
public boolean shallowEquals(Node other)
{
if (!sameClass(this, other)) {
return false;
}

SampledRelation otherRelation = (SampledRelation) other;
return type == otherRelation.type && Objects.equals(samplePercentage, otherRelation.samplePercentage);
}
}
28 changes: 28 additions & 0 deletions presto-tests/src/test/java/io/prestosql/tests/TestTablesample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,32 @@ public void testInvalidRatioType()
.hasErrorCode(TYPE_MISMATCH)
.hasMessage("line 1:61: Sample percentage should be a numeric expression");
}

@Test
public void testInSubquery()
{
// zero sample
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (0))"))
.matches("VALUES BIGINT '0'");

// full sample
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (100))"))
.matches("VALUES BIGINT '15000'");

// 1%
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (1))"))
.satisfies(result -> assertThat((Long) result.getOnlyValue()).isBetween(50L, 450L));

// 0.1%
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (1e-1))"))
.satisfies(result -> assertThat((Long) result.getOnlyValue()).isBetween(3L, 45L));

// 0.1% as decimal
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (0.1))"))
.satisfies(result -> assertThat((Long) result.getOnlyValue()).isBetween(3L, 45L));

// fraction as long decimal
assertThat(assertions.query("SELECT count(*) FROM tpch.tiny.orders WHERE orderkey IN (SELECT orderkey FROM tpch.tiny.orders TABLESAMPLE BERNOULLI (0.000000000000000000001))"))
.satisfies(result -> assertThat((Long) result.getOnlyValue()).isBetween(0L, 5L));
}
}