chore: refresh bun dependencies - #1109
Merged
Merged
Conversation
Signed-off-by: Hardik Shingala <hardik@traycer.ai>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe change updates router load detection in the history prune provider and refreshes dependency versions in the root and protocol manifests. ChangesRouter load detection
Dependency version refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06f90ac37f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Signed-off-by: Hardik Shingala <hardik@traycer.ai>
…cies-2026-08-11 Signed-off-by: Hardik Shingala <hardik@traycer.ai>
hdkshingala
added a commit
that referenced
this pull request
Aug 11, 2026
…ackend Signed-off-by: Hardik Shingala <hardik@traycer.ai>
pranshugupta54
added a commit
that referenced
this pull request
Aug 12, 2026
… hold TanStack router at pre-refresh pins (#1136) ## What Two commits, one failure mode: fresh mobile installs of the Capacitor app booted to a permanently blank screen. 1. **Guard (`bindAuthInvalidation`)** — on cold launch, the auth status flips (stored tokens validating) while the router's initial load is still uncommitted. On router-core ≥1.171.16, `invalidate()` in that window retires the in-flight load and nothing reschedules it: `status: "pending"`, zero committed matches, forever — no error anywhere. The binding now detects the uncommitted window via `resolvedLocation` (`matches` is not a commit signal — slow loads publish provisional pending matches after `defaultPendingMs`) and routes the auth change through `router.load()` first, invalidating once it settles; recoveries are coalesced to one per window since `load()` aborts its predecessor transaction. Behavior on the held router version is unchanged (recheck lands a few ms later). 2. **Version hold** — the bump that exposed this (#1109: react-router 1.170.18→.25, router-core 1.171.15→.21) crosses router-core's lane-scheduler rewrite, which is still churning upstream (1.171.22 shipped another ~1600-line pass over the same area yesterday). Held back to the last field-proven set: `react-router@1.170.18` (exact; pins core 1.171.15 exactly) + `router-plugin@1.168.23` (exact; newer plugin requires `^1.170.25` and splits the resolution into two router-core copies). The `history-prune-provider` adaptation from #1109 is restored to match. The guard stays regardless — it makes the pattern safe on any version, including future re-bumps. ## Verification - 10 unit tests + 1 integration test mounting a real `RouterProvider` against the pinned library (slow uncommitted first load past `pendingMs` → real auth flip → converges; fails without the guard). - iOS simulator, Release staging build, cold launches: pre-fix mostly blank; post-fix **12/12 render** across three install modes — upgrade-in-place, reinstall with surviving Keychain tokens (the exact reported death mode: auto-sign-in mid-boot), and never-signed-in. - Adversarial review by a GPT-5.6-Sol agent: two findings in the first pass (false commit signal via `matches`; un-coalesced recovery fan-out) — both fixed and re-verified; final pass clean on auth flows, redirect loops, deep links, desktop multi-window, and hydration paths. ## Notes - Root-caused end-to-end in the simulator (fiber-probe of the stuck router; manual `load()` revived it). - The mobile-app branch carries the same guard commit; it will converge on sync after this merges. Cc @hdkshingala --------- Signed-off-by: Pranshu Gupta <76090263+pranshugupta54@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Still held
Verification