Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To support commonjs #274

Merged
merged 1 commit into from
Nov 27, 2022
Merged

To support commonjs #274

merged 1 commit into from
Nov 27, 2022

Conversation

bj-white
Copy link

@bj-white bj-white commented Nov 9, 2022

A good library, but it does not support commonjs syntax. After such transformation, perfect support. Please use, thank you.

@fej-snikduj
Copy link

would love to see this supported

Copy link
Owner

@travist travist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I am going to give it a try.

@travist travist merged commit 546271e into travist:master Nov 27, 2022
@travist
Copy link
Owner

travist commented Nov 27, 2022

I need to revert this. It is breaking the automated tests. Please fix those and re-submit.

@bj-white bj-white deleted the support-commonjs branch December 2, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants