Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jeweler and clean up gemspec #392

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mishina2228
Copy link
Contributor

The Jeweler task was removed many years ago. 4b7e14b
But only the dependency remained.
This PR removes Jeweler and cleans up gemspec.
Here are the details:

@joshuacronemeyer
Copy link
Collaborator

We still use jeweler. It gives us some handy rake tasks by default like rake install and rake release and I use those when i make a new release. However I am interested in the gem spec cleanup you did. Can u update the PR to just cleanup gem spec?

@mishina2228
Copy link
Contributor Author

We still use jeweler. It gives us some handy rake tasks by default like rake install and rake release and I use those when i make a new release.

No worry, both rake install and rake release are given from Bundler.

$ bundle exec rake -T
rake build            # Build timecop-0.9.5.gem into the pkg directory
rake build:checksum   # Generate SHA512 checksum if timecop-0.9.5.gem into the checksums directory
rake clean            # Remove any temporary products
rake clobber          # Remove any generated files
rake clobber_rdoc     # Remove RDoc HTML files
rake default          # Default: run tests
rake install          # Build and install timecop-0.9.5.gem into system gems
rake install:local    # Build and install timecop-0.9.5.gem into system gems without network access
rake rdoc             # Build RDoc HTML files
rake release[remote]  # Create tag v0.9.5 and build and push timecop-0.9.5.gem to rubygems.org
rake rerdoc           # Rebuild RDoc HTML files

It may not be exactly the same as what Jeweler provides, but it probably won't be a problem.

@mishina2228
Copy link
Contributor Author

Scheduled CI fails now, but the reason is as noted at #397 (comment).
CI should be green if both this PR and #397 are merged.

@joshuacronemeyer joshuacronemeyer merged commit 48806e1 into travisjeffery:master Dec 12, 2022
@mishina2228 mishina2228 deleted the remove-jeweler branch December 13, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants