yarn should run with --pure-lockfile

[domoritz]

Without this option travis might overwrite the lockfile and it's hard to catch if the lockfile is out of date.

[BanzaiMan]

It seems best to override the default command in that case.

[BanzaiMan]

There was another person who wanted this as well.

@Daniel15 Do you have opinions on this?

[edmorley]

I was about to file an issue for this -- though I'd recommend using --frozen-lockfile instead, since it's closer to the desired effect (catch accidental config drift and quickly identify root cause). (Whereas --pure-lockfile uses yarn.lock regardless of whether it's out of date, and ignores package.json.)

The description from yarn help install...

--no-lockfile                   don't read or generate a lockfile
--pure-lockfile                 don't generate a lockfile
--frozen-lockfile               don't generate a lockfile and fail if an update is needed

[BanzaiMan]

OK. We'll move to --frozen-lockfile.

[Daniel15]

This sounds reasonable to me. @bestander @kittens What do you think?

[bestander]

Agree

[BanzaiMan]

Reopening this since we've received some error reports and reverted the fix.

[BanzaiMan]

A use case travis-ci/travis-build#997 (comment) raised was that Greenkeeper trying to update dependencies.

At the moment, the only flag we use for installing yarn (when it is not available on the image) is the presence of yarn.lock, so this puts such a use case in a conundrum. Though they can override install to overcome it, I think it is best to wait until all the build images have a recent version of yarn pre-installed.

[BanzaiMan]

On a second thought, the greenkeeper case is one where the user should override install. Eventually.

[BanzaiMan]

There was also a case where a pre-installed yarn flagged the build script to not install the latest version of yarn, where --frozen-lockfile was not available.

That should be accounted for.

[itsdouges]

Hey!

I'm getting an error error: unknown option --frozen-lockfile' when running with docker service (turning it off makes it work!):

services:
  - docker

Any ideas?

Heres my build: https://travis-ci.org/madou/armory-back/builds/214476264

[ismay]

@Madou So yarn is currently broken when also using docker services on travis? Because my builds are also failing with error: unknown option --frozen-lockfile'...

See: https://travis-ci.org/forecastxl/prototype/builds/214613995

[bestander]

--frozen-lockfile was added around Yarn v0.20 What version do you use?

…

On 24 March 2017 at 11:45, ismay ***@***.***> wrote: @Madou <https://github.com/madou> So yarn is currently broken when also using docker services on travis? Because my builds are also failing with error: unknown option --frozen-lockfile'... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7395 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWNFWOOSRj0A6P4in78Ga9xvr3kgMks5ro6z3gaJpZM4MNiYx> .

[ismay]

What version do you use?

@bestander Just the version that travis installs automatically (when a yarn.lock is present)

[itsdouges]

@bestander as @ismay said, looks like we're both using whatever travis installs.

@ismay seems like it.

when I turned it off (see: https://travis-ci.org/madou/armory-back/jobs/214557773) it got past the install dependencies stage.

weird stuff!

[ismay]

@Madou Yeah. Seems like yarn --frozen-lockfile is now run by default on travis builds for repos with a yarn.lock, but apparently with an outdated version of yarn which doesn't support that option?

Can't find a reference to the version of yarn that's being used in the build log though. Also weird that enabling docker makes it fail..

[itsdouges]

in retrospect maybe its sudo: true. can't play with travis atm to find out though :-).

[BanzaiMan]

@ismay

Seems like yarn --frozen-lockfile is now run by default on travis builds for repos with a yarn.lock, but apparently with an outdated version of yarn which doesn't support that option?

See travis-ci/travis-build#997 and the comments.

We have reverted this change, so restarting the failing jobs should work.

[itsdouges]

@BanzaiMan do you need to do something special for the jobs that use sudo? because it still isn't working.

see build I just ran: https://travis-ci.org/madou/armory-back/builds/214563501

[ismay]

@BanzaiMan @Madou

We have reverted this change, so restarting the failing jobs should work.

Not for me, I've restarted the build several times, but it keeps failing. I'm not installing my own version of yarn, so the installation of yarn is being handled by travis: https://travis-ci.org/forecastxl/prototype/builds/214613995#L311

[BanzaiMan]

@Madou @ismay I am so sorry about that. It is now deployed. Please restart your builds again.

[ismay]

@BanzaiMan That did it for me, thanks for the quick fix!

[itsdouges]

Thanks @BanzaiMan !

[stale]

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

[mmermerkaya]

Can you reconsider this?

More than a year has passed and the default Yarn version has supported --frozen-lockfile for a while now.

[bestander]

We are working out a solution for this, there should be another issue open

…

On Fri, May 4, 2018 at 12:35 PM Mertcan Mermerkaya ***@***.***> wrote: Can you reconsider this? More than a year has passed and the default Yarn version has supported --frozen-lockfile for a while now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7395 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWJx6XdgMbfFiogSuNsWEpc5ESEf8ks5tvK1ygaJpZM4MNiYx> .

[mmermerkaya]

Thanks! There's a somewhat similar issue about NPM's lock file, but I commented here because I couldn't find any other open issue about this for Yarn.

[chocolateboy]

Related: https://travis-ci.community/t/run-yarn-with-frozen-lockfile-when-yarn-lock-is-present/3396