Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document versions policy stuff #128

Merged
merged 8 commits into from
Feb 21, 2018
Merged

Document versions policy stuff #128

merged 8 commits into from
Feb 21, 2018

Conversation

philpennock
Copy link
Contributor

@philpennock philpennock commented Feb 16, 2018 •
edited by AlekSi
Loading

Closes #70.

@philpennock philpennock mentioned this pull request Feb 17, 2018
Merged
@philpennock
Add .x resolution and --resolve command
fd746b1 
* New persistent file, `~/.gimme/versions/known-versions.txt`, which is
  kept in sorted unique order
* Add `--resolve` for handling version specifiers in a
  normally-lightweight manner, where stdout gets the resolved version.
* Handle `NN.x` (and `NN.MM.x`) as a version specifier, against the
  known versions
* Have the `--known` output be cached to disk; there's a cache bypass
  mechanism (flag), and a cache age control environment variable.
* Rework some cache handling stuff to be in cleaner functional
  abstractions
* Adds a `_version_sort` filter
* Bug-fix for stable age using access-time not mod-time on darwin|*bsd

See the README updates for notes on interaction between `--resolve` and
git tag resolution, and how to avoid that.

Fixes #129
Resolves #110
@philpennock
version sort in --list output
27c3461 
1.1 1.10 1.2 is bad.
1.1 1.2 .. 1.9 1.10 is good.
@philpennock
Copy link
Contributor Author

NB: Do not merge until #130 is approved and merged into this; GitHub handles stacked PRs very badly.
(In turn, #130 needs #131 merged into it)

@AlekSi
Copy link
Contributor

AlekSi commented Feb 21, 2018

Edited first comment to convert a text reference to a link.

@AlekSi AlekSi mentioned this pull request Feb 21, 2018
Merged
philpennock and others added 4 commits February 21, 2018 13:07
@philpennock
resolve version via ENV; fix documented flag
7dd7a51 
Addresses review comments by @AlekSi
@philpennock
Make the versions dir if doesn't exist
555f15e 
Another issue caught by AlekSi: the code updating the known versions
didn't handle `~/.gimme/versions/` not already existing.
@meatballhat
Merge pull request #131 from travis-ci/resort_dash_l
ef7d682 
version sort in --list output
@meatballhat
Merge pull request #130 from travis-ci/dotx_support
e61f3e6 
Add .x resolution and --resolve command
meatballhat
meatballhat approved these changes Feb 21, 2018
View reviewed changes
Copy link
Contributor

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎺 🐢

@philpennock philpennock merged commit 5d537b3 into master Feb 21, 2018
@philpennock philpennock deleted the doc_versions_policy branch February 21, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@meatballhat meatballhat meatballhat approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philpennock @AlekSi @meatballhat