Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use 'upload' instead of 'push' #1227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to use 'upload' instead of 'push' #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d66b0
Update to use 'upload' instead of 'push'
fcole90 Dec 6, 2020
1877b47
Update snap_spec.rb
fcole90 Dec 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dpl/providers/snap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class Snap < Provider
update_snapd: 'sudo apt-get install snapd',
install: 'sudo snap install snapcraft --classic',
login: 'echo "%{token}" | snapcraft login --with -',
deploy: 'snapcraft push %{snap_path} --release=%{channel}'
deploy: 'snapcraft upload %{snap_path} --release=%{channel}'

msgs login: 'Attemping to login ...',
no_snaps: 'No snap found matching %{snap}',
Expand Down
6 changes: 3 additions & 3 deletions spec/dpl/providers/snap_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
it { should have_run '[apt:get] snapd (snap)' }
it { should have_run 'sudo snap install snapcraft --classic' }
it { should have_run 'echo "token" | snapcraft login --with -' }
it { should have_run 'snapcraft push ./snap --release=edge' }
it { should have_run 'snapcraft upload ./snap --release=edge' }
it { should have_run_in_order }
end

describe 'given --snap ./sn*' do
it { should have_run 'snapcraft push ./snap --release=edge' }
it { should have_run 'snapcraft upload ./snap --release=edge' }
end

describe 'given --snap ./snap --channel channel' do
it { should have_run 'snapcraft push ./snap --release=channel' }
it { should have_run 'snapcraft upload ./snap --release=channel' }
end

describe 'given --snap ./snap', run: false do
Expand Down