Lh 393 creating a image #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baegofda
reviewed
Apr 4, 2023
|
|
||
| /** 이미지 설명을 추가합니다. */ | ||
| alt: string; | ||
| } |
There was a problem hiding this comment.
P4: 태그에 기본적으로 들어가는 src, width, height, alt는 자동완성이 지원이 되니까 Props에서는 지우는게 어떨까요?
There was a problem hiding this comment.
width, height만 삭제하는걸로 소통완료
| <img | ||
| ref={ref} | ||
| src={src} | ||
| alt={alt} |
There was a problem hiding this comment.
P4: type Props부분과 동일하게 컴포넌트내의 props랑 <img />태그에도 정리가 되면 좋을 것 같습니당
| <img | ||
| src={ | ||
| "data:image/gif;base64, iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mO8UA8AAiUBUcc3qzwAAAAASUVORK5CYII=" | ||
| } |
There was a problem hiding this comment.
P4: 로드시 노출되는 이미지에도 loading={lazy ? "lazy" : "eager"}가 있는게 좋을까용?
| @@ -0,0 +1,2 @@ | |||
| export { Image } from "./Image"; | |||
| export type { ImageProps } from "./Image"; | |||
There was a problem hiding this comment.
P3: 이 부분은 혹시 로컬에서 에러가 안나오는 상황일까용? ImageProps는 Image.type에서 불러와야할 것 같습니다!
LH-393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LH-393
수정한 내용
추가적으로 알리고 싶은 내용