Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LH-374/selection #22

Merged
merged 23 commits into from
May 8, 2023
Merged

LH-374/selection #22

merged 23 commits into from
May 8, 2023

Conversation

baegofda
Copy link
Contributor

@baegofda baegofda commented May 8, 2023

목적

  • Selection 관련 컴포넌트 추가

추가적으로 알리고 싶은 내용

  • SelectDropBox의 경우 범용성을 위한 Dropdown 컴포넌트를 추가하였습니다.

@baegofda baegofda requested a review from sgd122 May 8, 2023 00:41
@baegofda baegofda self-assigned this May 8, 2023
baegofda added 19 commits May 8, 2023 09:54
@baegofda
feat(toggle): Toggle 컴포넌트 추가
f969979 
LH-374
@baegofda
fix(toggle): export 누락
b1ccdd6
@baegofda
feat(selectButton): SelectButton 컴포넌트 작업중
385304a 
LH-374
@baegofda
fix: inline-flex 수정
5456dd8
@baegofda
fix: 타입 수정
09d6b45
@baegofda
feat(selectButton): SelectButton 컴포넌트 추가
5add6fd 
LH-374
@baegofda
fix: 불필요한 children 제거
537dd52
@baegofda
feat(selectRadio): SelectRadio 컴포넌트 추가
06aaaba 
LH-374
@baegofda
feat(selectCheck): SelectCheck 컴포넌트 추가
0ca829d 
LH-374
@baegofda
feat(selectCheckBox): SelectCheckBox 컴포넌트 추가
b1a8c95 
LH-374
@baegofda
feat(dropdown): Dropdown 공통 컴포넌트 제작
82f7e52 
LH-374
@baegofda
fix(selectCheckBox): 스토리북 경로 수정
c5854a9 
LH-374
@baegofda
fix(dropdown): 스타일 초기화
d2d9e86 
LH-374
@baegofda
fix(dropdown): 불필요한 props 정리
119e421 
LH-374
@baegofda
feat(selectDropBox): SelectDropBox 컴포넌트 추가
4305ce4 
LH-374
@baegofda
fix: 최대 높이 추가
af744e6 
LH-374
@baegofda
fix: 말줄임 추가
56edb44 
LH-374
@baegofda
fix: export 누락
93bdbf1 
LH-374
@baegofda
fix: divider 색상 변경
89b8f06 
LH-374
@baegofda baegofda force-pushed the LH-374/selection branch from fb0e545 to 89b8f06 Compare May 8, 2023 00:55
sgd122
sgd122 reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@sgd122 sgd122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대면소통진행한 부분까지해서 아래에 작성해두었습니다~!

packages/travelmakers-design-core/src/components/Selection/SelectCheck/SelectCheck.tsx Outdated Show resolved Hide resolved
...kers-design-core/src/components/Selection/SelectDropBox/SelectDropBox/SelectDropBox.style.ts Outdated Show resolved Hide resolved
...velmakers-design-core/src/components/Selection/SelectDropBox/SelectDropBox/SelectDropBox.tsx Show resolved Hide resolved
packages/travelmakers-design-core/src/components/Selection/SelectRadioItem/SelectRadioItem.tsx Show resolved Hide resolved
@baegofda baegofda changed the title Lh 374/selection LH-374/selection May 8, 2023
@baegofda baegofda merged commit 622078c into main May 8, 2023
@baegofda baegofda deleted the LH-374/selection branch May 8, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgd122 sgd122 sgd122 left review comments

Assignees

@baegofda baegofda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baegofda @sgd122