Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LH-377/tab #18

Merged
merged 10 commits into from
Apr 25, 2023
Merged

LH-377/tab #18

merged 10 commits into from
Apr 25, 2023

Conversation

baegofda
Copy link
Contributor

목적

  • PrimaryTab 컴포넌트 제작
  • TertiaryTab 컴포넌트 제작

추가적으로 알리고 싶은 내용

  • id 자동 생성을 위한 useId() hooks 추가

@baegofda baegofda requested a review from sgd122 April 24, 2023 10:15
@baegofda baegofda self-assigned this Apr 24, 2023
Copy link
Contributor

@sgd122 sgd122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 부분보다 스토리북에 default value에 대해서 보지 못한 부분이 있었던것 같네요.
웬만하면 defaultValue를 설정을 하고

export const Default = (props) => {
return ( <Tab {...props} /> )

props를 통해서 값을 가져오는 형태로 하면 좋을 것 같습니다~!

@baegofda baegofda merged commit 6e05864 into main Apr 25, 2023
@baegofda baegofda deleted the LH-377/tab branch April 25, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants