-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LH-377/tab #18
Merged
Merged
LH-377/tab #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgd122
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다른 부분보다 스토리북에 default value에 대해서 보지 못한 부분이 있었던것 같네요.
웬만하면 defaultValue
를 설정을 하고
export const Default = (props) => {
return ( <Tab {...props} /> )
props를 통해서 값을 가져오는 형태로 하면 좋을 것 같습니다~!
packages/travelmakers-design-core/src/components/Tab/PrimaryTab/PrimaryTab.style.ts
Outdated
Show resolved
Hide resolved
packages/travelmakers-design-core/src/components/Tab/PrimaryTabItem/PrimaryTabItem.style.ts
Show resolved
Hide resolved
packages/travelmakers-design-core/src/components/Tab/TertiaryTab/TertiaryTab.style.ts
Outdated
Show resolved
Hide resolved
packages/travelmakers-design-core/src/components/Input/stories/Input.stories.tsx
Show resolved
Hide resolved
packages/travelmakers-design-core/src/components/Tab/PrimaryTab/stories/PrimaryTab.stories.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
추가적으로 알리고 싶은 내용