LH-373/progress #13
Merged
LH-373/progress #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgd122
reviewed
Apr 10, 2023
packages/travelmakers-design-core/src/components/Process/Process/Process.style.ts
Outdated
Show resolved
Hide resolved
| height: "100%", | ||
| padding: "0 11px", | ||
| color: isProcessing ? colors.white : colors.primary3, | ||
| ...typography.body3, |
There was a problem hiding this comment.
p5; ...typography.body3,는 최상단으로 옮기는게 가독성이 더 좋지 않을까요?
There was a problem hiding this comment.
흐흐.. 제 머릿속의 css 순서대로 맞추다보니 ㅋㅋ 수정하는게 좋겠네요!
There was a problem hiding this comment.
@baegofda 넵, 수ㅡ정 후 배포부탁드립니다~!
| flexDirection: "column", | ||
| justifyContent: "center", | ||
| height: "100%", | ||
| padding: "0 11px", |
There was a problem hiding this comment.
p5; 여기 padding 부분도 디자인시스템 미적용되는 부분인건가요?? ㅠ_ㅠ
There was a problem hiding this comment.
넵.. 아니면 그냥 해당 item의 width가 67px로 고정이라서 그 사이즈로 맞추면 되긴하는데 왠만하면 고정사이즈 보다는 padding등으로 사이즈 맞추는걸 선호해서용 🥲
There was a problem hiding this comment.
@baegofda 그러게요...고정보다는 padding이 있는게 좋긴할것 같아요. 디자인시스템내 패딩값이랑 동일하면 베스트일것같지만...어쩔수없을지도
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적