use correct config provider#101
Closed
zeitlinger wants to merge 2 commits intotrask:declarative-config/spring-step-onefrom
Closed
use correct config provider#101zeitlinger wants to merge 2 commits intotrask:declarative-config/spring-step-onefrom
zeitlinger wants to merge 2 commits intotrask:declarative-config/spring-step-onefrom
Conversation
trask
reviewed
Dec 26, 2025
| Runtime.getRuntime().addShutdownHook(new Thread(sdk::close)); | ||
| logStart(); | ||
| return sdk; | ||
| return new SpringOpenTelemetrySdk(sdk, SpringConfigProvider.create(model)); |
Owner
There was a problem hiding this comment.
since we're already converting the yaml into declarative config model above (in order to support DeclarativeConfigurationCustomizers), why do it again in SpringConfigProvider?
Author
There was a problem hiding this comment.
I think the type coersion was needed.
I may have been wrong - but then we should remove spring config provider altogether.
Owner
There was a problem hiding this comment.
good point, I've removed the spring config provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.