Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run type checks also for companion and add files to docker #4688

Merged
merged 7 commits into from
Sep 23, 2023

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Sep 19, 2023

theory: this PR's build should fail with

#23 22.96 node_modules/@szmarczak/http-timer/dist/source/index.d.ts(25,18): error TS2430: Interface 'ClientRequestWithTimings' incorrectly extends interface 'ClientRequest'.
#23 22.96   The types returned by 'setTimeout(...)' are incompatible between these types.
#23 22.96     Type 'ClientRequest' is not assignable to type 'this'.
#23 22.96       'ClientRequest' is assignable to the constraint of type 'this', but 'this' could be instantiated with a different subtype of constraint 'ClientRequest'.
#23 ERROR: process "/bin/sh -c cd /app && corepack yarn workspace @uppy/companion build" did not complete successfully: exit code: 1

#22 [linux/arm64 build 7/9] RUN apk --update add  --virtual native-dep   make gcc g++ python3 libgcc libstdc++ git &&   (cd /app && corepack yarn workspaces focus @uppy/companion) &&   apk del native-dep
#22 CANCELED
------
 > [linux/amd64 build 8/9] RUN cd /app && corepack yarn workspace @uppy/companion build:
22.96 node_modules/@szmarczak/http-timer/dist/source/index.d.ts(25,18): error TS2430: Interface 'ClientRequestWithTimings' incorrectly extends interface 'ClientRequest'.
22.96   The types returned by 'setTimeout(...)' are incompatible between these types.
22.96     Type 'ClientRequest' is not assignable to type 'this'.
22.96       'ClientRequest' is assignable to the constraint of type 'this', but 'this' could be instantiated with a different subtype of constraint 'ClientRequest'.

@mifi
Copy link
Contributor Author

mifi commented Sep 19, 2023

it did not fail 🤦‍♂️

.github/workflows/companion.yml Outdated Show resolved Hide resolved
@mifi mifi changed the title run type checks also for companion run type checks also for companion and add files to docker Sep 21, 2023
@mifi mifi requested review from arturi and Murderlon September 21, 2023 10:04
@arturi
Copy link
Contributor

arturi commented Sep 21, 2023

From Slack (so we remember what happened in the future):

i think the problem with publishing the Docker image could be that we don't COPY everything into the image
stuff like tsconfig.json might be needed
it's probably safer to just copy everything

.dockerignore Show resolved Hide resolved
@mifi mifi merged commit 889653e into main Sep 23, 2023
@mifi mifi deleted the companion-focused-build branch September 23, 2023 04:56
github-actions bot added a commit that referenced this pull request Sep 29, 2023
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/audio               |   1.1.3 | @uppy/store-default       |   3.0.4 |
| @uppy/aws-s3              |   3.3.1 | @uppy/store-redux         |   3.0.4 |
| @uppy/aws-s3-multipart    |   3.7.0 | @uppy/svelte              |   3.1.0 |
| @uppy/companion           |   4.9.1 | @uppy/thumbnail-generator |   3.0.5 |
| @uppy/companion-client    |   3.4.1 | @uppy/transloadit         |   3.3.1 |
| @uppy/compressor          |   1.0.4 | @uppy/tus                 |   3.3.1 |
| @uppy/core                |   3.5.1 | @uppy/utils               |   5.5.1 |
| @uppy/dashboard           |   3.5.4 | @uppy/webcam              |   3.3.3 |
| @uppy/image-editor        |   2.2.1 | @uppy/xhr-upload          |   3.4.1 |
| @uppy/remote-sources      |   1.0.4 | uppy                      |  3.17.0 |

- meta: add Prettier (Antoine du Hamel / #4707)
- @uppy/aws-s3-multipart: retry signature request (Merlijn Vos / #4691)
- meta: update linter config to cover more files (Mikael Finstad / #4706)
- @uppy/image-editor: ImageEditor.jsx - remove 1px black lines (Evgenia Karunus / #4678)
- meta: delete `.yarn/releases/yarn-3.4.1.cjs` (Antoine du Hamel)
- meta: fix linter errors (Antoine du Hamel / #4704)
- @uppy/utils: test: migrate to Vitest for Uppy core and Uppy plugins (Antoine du Hamel / #4700)
- meta: run corepack yarn (Mikael Finstad)
- @uppy/companion: upgrade TS target (Mikael Finstad / #4670)
- @uppy/companion: use deferred length for tus streams (Mikael Finstad / #4697)
- @uppy/companion-client: fix a refresh token race condition (Mikael Finstad / #4695)
- meta: add companion hotfix doc (Mikael Finstad / #4683)
- meta: run type checks also for companion and add files to docker (Mikael Finstad / #4688)
- @uppy/svelte: revert breaking change (Antoine du Hamel / #4694)
- meta: Update yarn.lock (Artur Paikin)
- @uppy/companion: fix instagram/facebook auth error regression (Mikael Finstad / #4692)
- @uppy/aws-s3-multipart: aws-s3-multipart - call `#setCompanionHeaders` in `setOptions` (jur-ng / #4687)
- @uppy/svelte: Upgrade Svelte to 4 (frederikhors / #4652)
- @uppy/companion: add test endpoint for dynamic oauth creds (Mikael Finstad / #4667)
- meta: fix VITE_COMPANION_ALLOWED_HOSTS (Mikael Finstad / #4690)
- @uppy/companion: fix edge case for pagination on root (Mikael Finstad / #4689)
- @uppy/companion: fix onedrive pagination (Mikael Finstad / #4686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants