-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@uppy/core: improve performance of validating & uploading files #4402
Merged
Commits on Apr 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eff6876 - Browse repository at this point
Copy the full SHA eff6876View commit details -
Configuration menu - View commit details
-
Copy full SHA for d67a4a5 - Browse repository at this point
Copy the full SHA d67a4a5View commit details
Commits on Apr 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 435c71b - Browse repository at this point
Copy the full SHA 435c71bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 133600d - Browse repository at this point
Copy the full SHA 133600dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47e2980 - Browse repository at this point
Copy the full SHA 47e2980View commit details -
don't do it for every file added, as it's very slow instead do the check at the end when all files are added. this allows us to easily work with 10k+ files fixes #4389
Configuration menu - View commit details
-
Copy full SHA for 966d3e7 - Browse repository at this point
Copy the full SHA 966d3e7View commit details
Commits on Apr 6, 2023
-
Update packages/@uppy/core/src/Uppy.js
Co-authored-by: Antoine du Hamel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94a3385 - Browse repository at this point
Copy the full SHA 94a3385View commit details -
make restricter.validate validate everything
instead make more specific methods for sub-validation also rename validateTotals to validateAggregateRestrictions
Configuration menu - View commit details
-
Copy full SHA for 9f53afe - Browse repository at this point
Copy the full SHA 9f53afeView commit details -
improve errors and user feedback
- handle errors centrally so that we can limit the amount of toasts (informers) sent to the users (prevent flooding hundreds/thousands of them) - introduce FileRestrictionError which is a restriction error for a specific file - introduce isUserFacing field for RestrictionError
Configuration menu - View commit details
-
Copy full SHA for 734a456 - Browse repository at this point
Copy the full SHA 734a456View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4142923 - Browse repository at this point
Copy the full SHA 4142923View commit details -
- show "%{count} additional restrictions were not fulfilled" for any restriction errors more than 4 - refactor/rename methods - improve ghost logic/comments
Configuration menu - View commit details
-
Copy full SHA for a8fb99c - Browse repository at this point
Copy the full SHA a8fb99cView commit details
Commits on Apr 9, 2023
-
improve performance when uploading
- introduce new event "upload-start" that can contain multiple files - make a new patchFilesState method to allow updating more files - unify "upload-start" logic in all plugins (send it before files start uploading) - defer slicing buffer until we need the data - refactor to reuse code
Configuration menu - View commit details
-
Copy full SHA for bb0079f - Browse repository at this point
Copy the full SHA bb0079fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff3e580 - Browse repository at this point
Copy the full SHA ff3e580View commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b43864f - Browse repository at this point
Copy the full SHA b43864fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a84e3f6 - Browse repository at this point
Copy the full SHA a84e3f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00bd146 - Browse repository at this point
Copy the full SHA 00bd146View commit details
Commits on Apr 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2474b16 - Browse repository at this point
Copy the full SHA 2474b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ebda51 - Browse repository at this point
Copy the full SHA 5ebda51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33311d8 - Browse repository at this point
Copy the full SHA 33311d8View commit details
Commits on Apr 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bd6e0d6 - Browse repository at this point
Copy the full SHA bd6e0d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c21ba - Browse repository at this point
Copy the full SHA 73c21baView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.