Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/core: improve performance of validating & uploading files #4402

Merged
merged 21 commits into from
Apr 15, 2023

Commits on Apr 4, 2023

  1. show how many files are added when loading

    remake of #4388
    mifi committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    eff6876 View commit details
    Browse the repository at this point in the history
  2. add french (cherry pick)

    mifi committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d67a4a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Configuration menu
    Copy the full SHA
    435c71b View commit details
    Browse the repository at this point in the history
  2. refactor / fix lint

    mifi committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    133600d View commit details
    Browse the repository at this point in the history
  3. refactor/reduce duplication

    mifi committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    47e2980 View commit details
    Browse the repository at this point in the history
  4. pull out totals validation

    don't do it for every file added, as it's very slow
    instead do the check at the end when all files are added.
    this allows us to easily work with 10k+ files
    fixes #4389
    mifi committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    966d3e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Update packages/@uppy/core/src/Uppy.js

    Co-authored-by: Antoine du Hamel <[email protected]>
    mifi and aduh95 authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    94a3385 View commit details
    Browse the repository at this point in the history
  2. make restricter.validate validate everything

    instead make more specific methods for sub-validation
    also rename validateTotals to validateAggregateRestrictions
    mifi committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    9f53afe View commit details
    Browse the repository at this point in the history
  3. improve errors and user feedback

    - handle errors centrally so that we can limit the amount of toasts (informers) sent to the users (prevent flooding hundreds/thousands of them)
    - introduce FileRestrictionError which is a restriction error for a specific file
    - introduce isUserFacing field for RestrictionError
    mifi committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    734a456 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4142923 View commit details
    Browse the repository at this point in the history
  5. improvements

    - show "%{count} additional restrictions were not fulfilled" for any restriction errors more than 4
    - refactor/rename methods
    - improve ghost logic/comments
    mifi committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a8fb99c View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. improve performance when uploading

    - introduce new event "upload-start"  that can contain multiple files
    - make a new patchFilesState method to allow updating more files
    - unify "upload-start" logic in all plugins (send it before files start uploading)
    - defer slicing buffer until we need the data
    - refactor to reuse code
    mifi committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    bb0079f View commit details
    Browse the repository at this point in the history
  2. fix e2e build issue

    mifi committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    ff3e580 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. try to upgrade cypress

    maybe it fixes the error
    mifi committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    b43864f View commit details
    Browse the repository at this point in the history
  2. Revert "fix e2e build issue"

    This reverts commit ff3e580.
    mifi committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    a84e3f6 View commit details
    Browse the repository at this point in the history
  3. upgrade parcel

    mifi committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    00bd146 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. move mutation logic to end

    mifi committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    2474b16 View commit details
    Browse the repository at this point in the history
  2. remove FileRestrictionError

    merge it with RestrictionError
    mifi committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    5ebda51 View commit details
    Browse the repository at this point in the history
  3. fix silly bug

    looks like the e2e tests are doing its job 👏
    mifi committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    33311d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Configuration menu
    Copy the full SHA
    bd6e0d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73c21ba View commit details
    Browse the repository at this point in the history