Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes flagged by LGTM.com #1876

Merged
merged 3 commits into from
Oct 11, 2019
Merged

fixes flagged by LGTM.com #1876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
548622a
aws-s3-multipart: fix typo
goto-bus-stop Oct 11, 2019
2e5f7c6
form: fix comparison
goto-bus-stop Oct 11, 2019
0ca285d
companion-client: fix use strict directive
goto-bus-stop Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@uppy/aws-s3-multipart/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ module.exports = class AwsS3Multipart extends Plugin {
const token = file.serverToken
const host = getSocketHost(file.remote.companionUrl)
const socket = new Socket({ target: `${host}/api/${token}`, autoOpen: false })
this.uploaderSockets[socket] = socket
this.uploaderSockets[file.id] = socket
this.uploaderEvents[file.id] = new EventTracker(this.uppy)

this.onFileRemove(file.id, (removed) => {
Expand Down
3 changes: 2 additions & 1 deletion packages/@uppy/companion-client/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
'use-strict'
'use strict'

/**
* Manages communications with Companion
*/
Expand Down
1 change: 1 addition & 0 deletions packages/@uppy/companion-client/src/tokenStorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
'use strict'

/**
* This module serves as an Async wrapper for LocalStorage
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/@uppy/form/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ module.exports = class Form extends Plugin {

install () {
this.form = findDOMElement(this.opts.target)
if (!this.form || !this.form.nodeName === 'FORM') {
if (!this.form || this.form.nodeName !== 'FORM') {
this.uppy.log('Form plugin requires a <form> target element passed in options to operate, none was found', 'error')
return
}
Expand Down