e2e: reintroduce e2e test for providers locally #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will need a big rebase after #1675 :/ |
|
The main change in the new wdio is that you'll need lots of browser.someMethod('selector')now needs to be: const el = await browser.$('selector')
await el.someMethod() |
ifedapoolarewaju
force-pushed
the
providers-e2e-again
branch
from
c69e4ce to
e991169
Compare
|
@goto-bus-stop ready for a review now 👍 |
| @@ -8,7 +8,7 @@ const Dropbox = require('@uppy/dropbox') | |||
| const Tus = require('@uppy/tus') | |||
|
|
|||
| const isOnTravis = !!(process.env.TRAVIS && process.env.CI) | |||
| const companionUrl = isOnTravis ? 'http://companion.test:3030' : 'http://localhost:3030' | |||
| const companionUrl = isOnTravis ? 'http://companion.test:3030' : 'http://localhost:3020' | |||
There was a problem hiding this comment.
wdio runs Companion on :3030. can't we use that here?
There was a problem hiding this comment.
I resorted to 3020 for the following reasons:
- Oauth Redirect URI for the Providers in dev env is currently set to allow only http://localhost:3020
- I thought since this is meant to run locally there's no need to duplicate the usage of secrets nor is there a need to bother running a different companion instance.
I think the companion at 3030 serves for url-plugin on travis which does not need Oauth dance, also it made sense to have it because the other providers were intended to run on travis, but unfortunately, that's not the case anymore
There was a problem hiding this comment.
@goto-bus-stop any reservations on this?
goto-bus-stop
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.