Make providers support react native #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifedapoolarewaju
force-pushed
the
provider-react-native
branch
from
fac73ed to
eabf6f6
Compare
|
🎉 🥇 Awesome! Will this work if we use WebView for auth only? I guess yes, we get the token in the storage that can be used without WebView, directly in RN environment, right? |
|
@arturi I have updated the PR so that the URL will contain the |
arturi
reviewed
Feb 21, 2019
| @@ -422,7 +422,7 @@ module.exports = class ProviderView { | |||
| } | |||
|
|
|||
| handleAuth () { | |||
| const authState = btoa(JSON.stringify({ origin: location.origin })) | |||
| const authState = btoa(JSON.stringify({ origin: location.origin, redirect: 'http://localhost:3' })) | |||
| const link = `${this.provider.authUrl()}?state=${authState}` | |||
There was a problem hiding this comment.
yeah that's not meant to be there. Removed
|
Awesome news! Tested, seems to work with the browser. I’d need it merged in master, so I can easier test in RN branch. Left a small comment. |
This was referenced Dec 30, 2020
This was referenced Dec 31, 2020
This was referenced Aug 11, 2022
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
…ative Make providers support react native
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providers can be instantiated with a
storagemodule that behaves similarly tolocalStoragehereThe auth URL can also be called similarly as done here, but with an additional
redirectoption specified. Like so:If this is done on react-native (on the same window, not a new one), Companion will redirect to the redirect value set after the OAuth dance is done with a
uppyAuthTokenquery param passed.