Use separate jobs for each task #180
Conversation
Now the CI workflow runs on every pull request and every push to the main branch. This runs ESLint, Prettier, tsd, and Vitest, all in their own job. The Integration tests workflow runs on the main branch. It runs all tests, publishes a coverage badge, and sends a Slack notification on failure.
There was a problem hiding this comment.
I guess the advantage of having each command running as a separate job would be that they can be parallelised (and therefore faster)? a drawback could be that running more stuff in parallel is more expensive (because stuff like checkout/setup-node, yarn install all needs to be run 4 times). But because node-sdk is an open source project we have unlimited free action minutes so it doesn't matter.
|
The advantage is that now each tool has their own visual elements in various places in the GitHub UI, such as this PR. I.e. it’s immediately clear what failed from the overview at the bottom of this PR. Also it’s possible to re-run failed tasks only. Also, while it’s true that |
|
other than that lgtm! |
Now the CI workflow runs on every pull request and every push to the main branch. This runs ESLint, Prettier, tsd, and Vitest, all in their own job.
The Integration tests workflow runs on the main branch. It runs all tests, publishes a coverage badge, and sends a Slack notification on failure.