Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for generating signed Smart CDN URLs #92

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

Acconut
Copy link
Member

@Acconut Acconut commented Nov 22, 2024

We recently added support for signed Smart CDN URLs (see https://transloadit.com/docs/topics/signature-authentication/#smart-cdn) and would like our SDKs to offer methods for generating these signed URLs.

This PR adds such a method with tests.

@Acconut Acconut requested a review from cdr-chakotay November 22, 2024 14:10
@Acconut Acconut self-assigned this Nov 22, 2024
@Acconut
Copy link
Member Author

Acconut commented Nov 22, 2024

@cdr-chakotay
Copy link
Contributor

@cdr-chakotay Can you help me fix this linting error? https://github.com/transloadit/java-sdk/actions/runs/11974368156/job/33385298147#step:4:388

Sure! Will send you changes to circumvent this. (Need to get them uploaded from my IDE)

Copy link
Contributor

@cdr-chakotay cdr-chakotay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did now push the pending changes directly to circumvent the extra work:

  • replaced wildcard imports
  • dealt with trailing spaces
  • dealt with line length issues

@Acconut
Copy link
Member Author

Acconut commented Nov 26, 2024

Thank you very much!

@Acconut Acconut merged commit f698f64 into main Nov 28, 2024
5 checks passed
@Acconut Acconut deleted the smart-cdn-url-signature branch November 28, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants