Skip to content

Commit

Permalink
Socket io upgrade (#85)
Browse files Browse the repository at this point in the history
* Upgrade Socket- IO Library for Socket-IO-4
* Fix an example
  • Loading branch information
cdr-chakotay authored Oct 30, 2022
1 parent 65b340b commit abe3964
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 6 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### 0.4.4 / 2022-10-30 ###
* The Socket-IO plugin has been updated to version 4, which is also used by the API.

### 0.4.3 / 2022-10-28 ###
* Includes a vulnerability patch in the used socket-io implementation

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Existing users should take note of the [JCenter shutdown](https://jfrog.com/blog
**Gradle:**

```groovy
implementation 'com.transloadit.sdk:transloadit:0.4.3'
implementation 'com.transloadit.sdk:transloadit:0.4.4'
```

**Maven:**
Expand All @@ -29,7 +29,7 @@ implementation 'com.transloadit.sdk:transloadit:0.4.3'
<dependency>
<groupId>com.transloadit.sdk</groupId>
<artifactId>transloadit</artifactId>
<version>0.4.3</version>
<version>0.4.4</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dependencies {
implementation 'com.squareup.okhttp3:okhttp:4.10.0'
implementation 'org.json:json:20220924'
implementation 'commons-codec:commons-codec:1.15'
implementation 'io.socket:socket.io-client:1.0.2'
implementation 'io.socket:socket.io-client:2.1.0'
testImplementation 'junit:junit:4.13.2'
testImplementation 'org.mock-server:mockserver-junit-rule:5.14.0'
testImplementation 'org.mockito:mockito-core:4.8.0'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void onAssemblyResultFinished(String stepName, JSONObject result) {

try {
System.out.println("Processing... ");
System.out.println("Assembly ID: " + assembly.getAssemblyID());
System.out.println("Assembly ID: " + assembly.getClientSideGeneratedAssemblyID());
assembly.save(true);
} catch (LocalOperationException | RequestException e) {
e.printStackTrace();
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/java-sdk-version/version.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
versionNumber='0.4.3'
versionNumber='0.4.4'
2 changes: 1 addition & 1 deletion src/test/java/com/transloadit/sdk/RequestTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public void get() throws Exception {
mockServerClient.verify(HttpRequest.request()
.withPath("/foo")
.withMethod("GET")
.withHeader("Transloadit-Client", "java-sdk:0.4.3"));
.withHeader("Transloadit-Client", "java-sdk:0.4.4"));

}

Expand Down

0 comments on commit abe3964

Please sign in to comment.