Remove async assembly (#94)

* Remove Async Assemblies Files * Remove Async Assembly References * Remove Unused method * Update release comments * Apply suggestions from code review Co-authored-by: Marius Kleidl <[email protected]> --------- Co-authored-by: Marius Kleidl <[email protected]>
transloadit · Jan 13, 2025 · 7b14498 · 7b14498
1 parent 0f5128d
commit 7b14498
Show file tree

Hide file tree

Showing 15 changed files with 12 additions and 1,129 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,19 @@
 ### Not released yet ###
+#### Major Release 
 * Exchange the Socket based assembly status fetching with a Server-Sent-Events (SSE) solution.
 * Added new methods to the AssemblyListener interface to provide more information about the assembly status. e.g. encoding progress with AssemblyListener#onAssemblyProgress().
 * Changed existing methods in the AssemblyListener interface to provide the bare JSON response from the api instead of pre-parsed data.
+* Removed the deprecated AsyncAssemblies class and functionality.
+
+##### Breaking Changes - Upgrade Guide
+* The AssemblyListener interface has been upgraded. As a result you will have to implement the following methods:
+  - `onFileUploadFinished(JSONObject uploadInformation);`
+  - `onAssemblyProgress(JSONObject progress)`
+  - `onAssemblyResultFinished(JSONArray result)`
+
+* The AsyncAssembly class has been removed. If you were using it, you will have to switch to the regular Assembly class.
+  It has been extended with asynchronous upload capabilities in the past. 
+The Example under `examples/src/main/java/com/transloadit/examples/MultiStepProcessing.java` shows how to use the new features.
 ### 1.0.1 / 2024-11-28 ###
 * Added SDK support for generating signed Smart CDN URLs (see https://transloadit.com/docs/topics/signature-authentication/#smart-cdn).
   This functionality ships as Transloadit#getSignedSmartCDNUrl() - Method.

diff --git a/examples/src/main/java/com/transloadit/examples/async/AsyncExample.java b/examples/src/main/java/com/transloadit/examples/async/AsyncExample.java
diff --git a/examples/src/main/java/com/transloadit/examples/async/AsyncPausePlayExample.java b/examples/src/main/java/com/transloadit/examples/async/AsyncPausePlayExample.java
diff --git a/examples/src/main/java/com/transloadit/examples/async/package-info.java b/examples/src/main/java/com/transloadit/examples/async/package-info.java
diff --git a/src/main/java/com/transloadit/sdk/Assembly.java b/src/main/java/com/transloadit/sdk/Assembly.java
@@ -819,13 +819,4 @@ protected String obtainUploadUrlSuffix() {
             return "/assemblies/" + assemblyId;
         }
     }
-
-    /**
-     * Returns the current Thread List.
-     *
-     * @return List of Type TusUploadRunnable
-     */
-    protected ArrayList<TusUploadRunnable> getThreadList() {
-        return threadList;
-    }
 }
diff --git a/src/main/java/com/transloadit/sdk/Transloadit.java b/src/main/java/com/transloadit/sdk/Transloadit.java
@@ -1,8 +1,5 @@
 package com.transloadit.sdk;
 
-import com.transloadit.sdk.async.AssemblyProgressListener;
-import com.transloadit.sdk.async.UploadProgressListener;
-import com.transloadit.sdk.async.AsyncAssembly;
 import com.transloadit.sdk.exceptions.RequestException;
 import com.transloadit.sdk.exceptions.LocalOperationException;
 import com.transloadit.sdk.response.AssemblyResponse;
@@ -213,31 +210,6 @@ public Assembly newAssembly() {
         return new Assembly(this);
     }
 
-    /**
-     * Returns an AsyncAssembly instance that can be used to create a new assembly asynchronously.
-     * This method is good for running assemblies in the background
-     *
-     * @param listener an implementation of {@link UploadProgressListener} to serve as a callback
-     *                 for the asynchronous assembly.
-     * @return {@link AsyncAssembly}
-     */
-    public AsyncAssembly newAssembly(UploadProgressListener listener) {
-        return new AsyncAssembly(this, listener);
-    }
-
-    /**
-     * Returns an AsyncAssembly instance that can be used to create a new assembly asynchronously.
-     * This method is good for running assemblies in the background
-     *
-     * @param listener an implementation of {@link AssemblyProgressListener} to serve as a callback
-     *                 for the asynchronous assembly.
-     * @deprecated use {@link #newAssembly(UploadProgressListener)} instead
-     * @return {@link AsyncAssembly}
-     */
-    public AsyncAssembly newAssembly(AssemblyProgressListener listener) {
-        return new AsyncAssembly(this, listener);
-    }
-
     /**
      * Returns a single assembly.
      *

diff --git a/src/main/java/com/transloadit/sdk/async/AssemblyProgressListener.java b/src/main/java/com/transloadit/sdk/async/AssemblyProgressListener.java