Use husky to ensure eslint & prettier rules on git commits#643
Use husky to ensure eslint & prettier rules on git commits#643onnimonni wants to merge 1 commit intotransitive-bullshit:mainfrom
Conversation
|
@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
I was unable to review the PR due to technical issues - the system couldn't find the remote branch 'add-husky-to-fix-formatting-on-commits'. Here's my review based on the available information in the pull request: Pull Request Review: Add Husky for Formatting EnforcementOverviewThis PR adds Husky to enforce eslint and prettier rules on git commits, similar to what's implemented in the react-notion-x repository. This is a good practice that helps prevent formatting inconsistencies from being merged into the main branch. Positive Aspects
Suggestions
Questions
I recommend approving this PR once any documentation updates are included to help onboard other developers to the new workflow. |
When I was doing #642 I realized that my editor didn't automatically force the formatting rules and thus if it would have been merged the main branch would be failing it's tests.
By adding husky similiarly as we have in https://github.com/notionX/react-notion-x/ we can avoid these unnecessary issues which computers can automate for us.