Update ICU plural examples in JSON formats #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and/or solution
Update KEYVALUEJSON and STRUCTUREDJSON examples of pluralized
ICU strings, so that the starting keyword is the same as the
variable name.
For example {count, plural, one {{cnt} item} other {{cnt} items}}
is best written as {cnt, plural, one {{cnt} item} other {{cnt} items}}.
The reason is that many ICU libraries or frameworks will probably
require the two to be identical (
cnt
), notcount
for the keywordand
cnt
for the variable placeholder.How to test
Not much to test, it's a documentation change, really. The unit tests should pass, of course.
Reviewer checklist
Code:
PR: