This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
feat: Approval System #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows instances to approve users or deny them before they can sign in.
The current implementation that is done doesn't have a special interface as the sorting is done via the Users tab in instance settings currently if admins want to check unapproved accounts.
Control Panel > Users > State > Not ApprovedOn the moderation page of the users will be a new tab called "Approval" that will only be shown if the user viewed isn't approved,
Users that are waiting for an approval will get an "Approval Pending" email followed by an email stating they were accepted if an admin accepted them. if the admin decided to deny their registration request and clicked the "Deny & Delete account" button (Deletion is done to be in accordance with GDPR) the user will simply end up getting an "Account Deleted" email.
An warning will also be shown to visitors like it is already done with instances that are invite-only stating that the instance is approval only.
If instances don't have email setup as a requirement for new users it will simply show the user a dialog stating that their account has been created and is awaiting approval. this same dialog will also show after a user has verified their signup/email if email requirement is enabled.
WARNING
For instances that are already running Sharkey and instances that want to migrate from misskey or firefish please prompt your users to logout and log back in so their accounts default to approved in case you ever want to switch to approval required.
You can also run this query manually after the update is released to automatically set all accounts as approved:
Closes #84