-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-22306/B-22307 int deleted documents use db function #14774
Open
r-mettler
wants to merge
26
commits into
integrationTesting
Choose a base branch
from
B-22307-INT
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-20536 add queue management tracking to move history
…t sha for image, add more timeout on wait
enable server test 99% but allows to fail, force client on all PR, se…
B-21583 - update code to calculate gbloc for AK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-22306
B-22307
Summary
This PR contains B-22306 and B-22307. Previously the method used a Pop query that when called with includeDeletedDocs the query would sometimes fail to find an alias to the documents table and throw an error. Other cases the method would cause errors when trying to retrieve documents because it was retrieving files that were soft deleted (had a date in the deleted_at field). These backlogs introduce a new database function to retrieve only documents that have not been soft deleted.
Is there anything you would like reviewers to give additional scrutiny?
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Upload and delete every document you can and make sure it doesn't throw an error. Also create and delete things like moving expenses, weight tickets, and pro gear documents after you have uploaded documents and when you have not uploaded documents. Do this from the Customer and Office apps.
Make sure you can download an AOA packet and Payment Packet for PPMs as customer and office user.
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots