Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21962: Create Requested Users Report #14768

Open
wants to merge 11 commits into
base: integrationTesting
Choose a base branch
from

Conversation

TevinAdams
Copy link
Contributor

@TevinAdams TevinAdams commented Feb 7, 2025

Agility ticket

Summary

This PR is introducing exporting to the admin requested users list.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Access the admin app
  2. View requested office users list
  3. Select some requested office users records using the check boxes on the left
  4. Click the export button in the top right corner
  5. File should download

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@TevinAdams TevinAdams added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Feb 7, 2025
@TevinAdams TevinAdams self-assigned this Feb 7, 2025
@TevinAdams TevinAdams marked this pull request as draft February 7, 2025 00:51
@TevinAdams TevinAdams marked this pull request as ready for review February 7, 2025 16:53
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found something fun - in the case of multiple entries (I tested with two requested office users)

When I selected the checkbox next to both, THEN export - I get the comma separated list for a user that has multiple roles:
image
image

But if I just click export with hitting the checkboxes next to each row, I get a row for each role that the user has, instead of a comma separated list:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants