B-21961/I-13804: Pagination and Sorting on Transportation office

[TevinAdams]

Agility ticket

Issue ticket

Summary

In this PR the following has been added :

1. Fixing the pagination
2. Fixing sorting on Transportation Office
3. Refactor to a better implementation and approach

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the admin app

2. Go to the Requested Office Users Tab

3. Notice the roles are now showing on the list
   

4. Type in the Transportation Office Filter - I typed USAF
   

5. Type into the Roles Filter - I typed "Ta" for Task Ordering and Task Invoicing
   

6. Type into both filter
   

7. Sort list based on the different columns

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[danieljordan-caci]

When searching, I am getting results for approved users in there

[TevinAdams]

When searching, I am getting results for approved users in there

Checking on this now. Dang pop query

When searching, I am getting results for approved users in there

@danieljordan-caci Fixed. Needed to adjust the query a bit.

[danieljordan-caci]

Looks good! Tried out filtering/sorting with 4-5 different users, approved one and it wasn't showing up in the search anymore. Send it.

[cameroncaci]

Code isn't fully covered. Does meet issue ticket AC, but needs testing to future proof it

Screen.Recording.2025-02-07.at.8.59.46.AM.mov

[TevinAdams]

Code isn't fully covered. Does meet issue ticket AC, but needs testing to future proof it

Screen.Recording.2025-02-07.at.8.59.46.AM.mov

@cameroncaci as discussed via Slack. These lines are covered from test I put in pkg/handlers/adminapi. The "Go: Toggle Test Coverage Tool in Current package" does not take into account tests in other packages that covers these lines of code. I added additional tests in pkg/services/requested_office_users to cover some of these lines as well. Overall all lines are covered by a test. Test coverage in this package has now went from 80.9 to 85.7.