Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit UB weight allowance based on Studen Travel order type. #14396

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

brooklyn-welsh
Copy link
Contributor

Agility ticket

INT PRs

#14285
#14383

Summary

This branch limits the "Unaccompanied Baggage Weight" limit for a move to 350 lbs if the move order is of the "Student Travel" type. Note that currently there is no validation to ensure that Student Travel is only eligible for OCONUS moves, but since the intention is that this will only be an option for OCONUS, this weight limit functionality only works if you choose an origin or destination duty location that is OCONUS (e.g. Alaska).

How to test

  1. Enable the "FEATURE_FLAG_UNACCOMPANIED_BAGGAGE" FF in the .envrc and re-run make server_run
  2. Create a move with an OCONUS origin/destination duty location (I used Tok, AK)
  3. Create a UB Unaccompanied baggage shipment. (This weight limiting will work with any shipment type since it's on the order level, but the UB shipment gives us an extra UI spot to verify that the limiting is working).
  4. Sign for the move, then login as SC and access the move, you should see on the "Allowances" card that the "Unaccompanied Baggage" field shows 350 lbs:Screenshot 2024-11-26 at 3 07 48 PM
  5. Also check the shipment by clicking "Edit Shipment" on the UB shipment card, then verify that this also shows 350 lbs:
    Screenshot 2024-11-26 at 3 10 08 PM

P.S. you can also create moves without UB and instead have any other shipment type, and you should still see the "Allowances" card show 350 lbs as shown in step 4, you just won't get the UB shipment card as shown in step 5.

@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review December 18, 2024 21:07
@brooklyn-welsh brooklyn-welsh requested a review from a team as a code owner December 18, 2024 21:07
Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WeatherfordAaron WeatherfordAaron added ByteSize M&Ms Team ByteSized M&Ms MAIN labels Dec 18, 2024
Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@WeatherfordAaron WeatherfordAaron merged commit d352c1c into main Dec 19, 2024
42 checks passed
@WeatherfordAaron WeatherfordAaron deleted the MAIN-B-21577-student-travel-ub-limit branch December 19, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms MAIN
Development

Successfully merging this pull request may close these issues.

3 participants