-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main b 21671 db create re fsc multipliers #14332
Merged
brianmanley-caci
merged 13 commits into
main
from
MAIN-B-21671-DB-create-re_fsc_multipliers
Dec 10, 2024
Merged
Main b 21671 db create re fsc multipliers #14332
brianmanley-caci
merged 13 commits into
main
from
MAIN-B-21671-DB-create-re_fsc_multipliers
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaki-caci
requested review from
deandreJones,
danieljordan-caci,
brianmanley-caci,
begrohmann,
elizabeth-perkins,
samaysofo,
ryan-mchugh,
stevengleason-caci and
a team
December 4, 2024 20:09
danieljordan-caci
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits and code matches up
begrohmann
approved these changes
Dec 6, 2024
samaysofo
approved these changes
Dec 6, 2024
brianmanley-caci
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ryan-mchugh
approved these changes
Dec 10, 2024
brianmanley-caci
deleted the
MAIN-B-21671-DB-create-re_fsc_multipliers
branch
December 10, 2024 20:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21671
Int b 21671 PR
Summary
We are adding FSC multipliers table that will be used in the calculations for the price of the FSC.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
make db_dev_migrate
Database
Any new migrations/schema changes: