Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main b 21671 db create re fsc multipliers #14332

Merged
merged 13 commits into from
Dec 10, 2024

Conversation

msaki-caci
Copy link
Contributor

B-21671

Int b 21671 PR

Summary

We are adding FSC multipliers table that will be used in the calculations for the price of the FSC.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Test that the migrations work using make db_dev_migrate
  2. Verify the new table with the populated columns: id, low_weight, high_weight, multiplier, created_at, and updated_at. (I used Dbeaver)

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Create re_fsc_multipliers table
Create models for multipliers table
Add table to migrations manifest
Add inserts for re_fsc_multipliers table
Fix reference to re_fsc_multipliers table in mto_service_items
Remove fsc_multiplier from mto_service_items model
Consolidate the inserts migration file
Make the multiplier read only
Make ID for multiplier a PK
Fix typo
Add comment explaining why we are using a pointer for the Multiplier
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits and code matches up

Copy link
Contributor

@brianmanley-caci brianmanley-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brianmanley-caci brianmanley-caci merged commit 0280952 into main Dec 10, 2024
41 checks passed
@brianmanley-caci brianmanley-caci deleted the MAIN-B-21671-DB-create-re_fsc_multipliers branch December 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants