Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B-21676 exclude nsra15 duty locations #14328

Merged
merged 17 commits into from
Dec 11, 2024

Conversation

MInthavongsay
Copy link
Contributor

B-21676

INT PR

Summary

This PR addresses issue related to search AK duty locations that are classified as Level V(RateArea: NSRA15). Approximately 200+ AK duty locations have been classified as NSRA15 rate area. This PR updates the duty location search to exclude NSRA15 locations from search results.

NSRA15-duty-locations-data-1731515178779.csv

This PR contains migration file to flag specific re_oconus_rate_areas records as inactive(active=false). This flag serves as the basis for the exclusion mechanism. In addition, migration file also contains INSERTs to correct 18 duty locations not having any oconus rateAea mappings(provided by Beth Grohmann).

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

We want to verify each duty location identified as NSRA15 affiliated is excluded from search result by its formal name, alternative names and postal code. Note: duty locations are searchable by complete/partial name and postal code.

  1. Login as customer and start process of onboarding a move.
  2. Using the NSRA15 file attached to this PR, search names/postal codes and verify duty locations are not returned in search results. Make sure to also do a search only using its postal code.
  3. Search using known alternative names. Verify the alternative name does not return results containing its known location.
    ex)
    "Brevig Msn, AK 99785" or "Brevig Msn" or "99785" => Brevig Mission, AK 99785
    "Arctic Vlg, AK 99722" or ""Arctic Vlg" or 99722" => Arctic Village, AK 99722
    "Anaktuvuk, AK 99721" or "Anaktuvuk" or 99721" => Anaktuvuk Pass, AK 99721

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@MInthavongsay MInthavongsay self-assigned this Dec 4, 2024
@MInthavongsay MInthavongsay requested a review from a team as a code owner December 4, 2024 19:33
@MInthavongsay MInthavongsay marked this pull request as draft December 4, 2024 19:37
@MInthavongsay MInthavongsay marked this pull request as ready for review December 9, 2024 15:18
Copy link
Contributor

@r-mettler r-mettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as INT

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches!

@r-mettler r-mettler merged commit ab52632 into main Dec 11, 2024
42 checks passed
@r-mettler r-mettler deleted the B-21676-exclude-NSRA15-duty-locations branch December 11, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants