-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B-21676 exclude nsra15 duty locations #14328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto B-21676-exclude-NSRA15-duty-locations
…nto B-21676-exclude-NSRA15-duty-locations
…s that are not enabled
r-mettler
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as INT
antgmann
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches!
CoryKleinjanCACI
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21676
INT PR
Summary
This PR addresses issue related to search AK duty locations that are classified as Level V(RateArea: NSRA15). Approximately 200+ AK duty locations have been classified as NSRA15 rate area. This PR updates the duty location search to exclude NSRA15 locations from search results.
NSRA15-duty-locations-data-1731515178779.csv
This PR contains migration file to flag specific re_oconus_rate_areas records as inactive(active=false). This flag serves as the basis for the exclusion mechanism. In addition, migration file also contains INSERTs to correct 18 duty locations not having any oconus rateAea mappings(provided by Beth Grohmann).
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
We want to verify each duty location identified as NSRA15 affiliated is excluded from search result by its formal name, alternative names and postal code. Note: duty locations are searchable by complete/partial name and postal code.
ex)
"Brevig Msn, AK 99785" or "Brevig Msn" or "99785" => Brevig Mission, AK 99785
"Arctic Vlg, AK 99722" or ""Arctic Vlg" or 99722" => Arctic Village, AK 99722
"Anaktuvuk, AK 99721" or "Anaktuvuk" or 99721" => Anaktuvuk Pass, AK 99721
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots