MAIN B-20935 #14157
Merged
MAIN B-20935 #14157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljordan-caci
added
Mountain Movers
danieljordan-caci
requested review from
a team,
deandreJones,
TevinAdams,
cameroncaci and
traskowskycaci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT PR
Agility ticket
Summary
os.system= badsubprocess.run= mo bettuhsubprocess.run(): From what I've read, this function allows you to pass the command and arguments as a list, so no shell is invoked. This approach is safer than os.system() because it doesn’t mess with special shell characters (like &, ;, etc.), which could lead to command injections.Added in
check=Truebecause this flag makessubprocess.run()raise an exception if the command fails, which can be helpful for debugging.How to test