B-21375 UB Allowance Calculation - MAIN #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endment, SC editing order or allowance, TOO editing order or allowance
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
traskowskycaci
requested review from
a team,
deandreJones,
danieljordan-caci,
TevinAdams and
cameroncaci
|
awaiting upstream |
|
Upstream merge will solve conflicts, re #14288 (comment) |
|
main is locked this morning |
|
main unlocked |
|
Whats the reason for the change differences in pkg/models/entitlements_test.go? |
danieljordan-caci
approved these changes
Dec 10, 2024
@TevinAdams just double checked that integration is the same as main here: https://github.com/transcom/mymove/blob/integrationTesting/pkg/models/entitlements_test.go |
Okay thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please ensure the upstream, B-21374, is merged into main first
B-21375 INT PR
B-21375 I-13559 INT PR
This PR contains the commits from the two integration PRs above.